Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindCriterion.cmake module #557

Open
wants to merge 1 commit into
base: bleeding
Choose a base branch
from

Conversation

petk
Copy link

@petk petk commented Dec 27, 2024

  • CMake minimum required version bumped to 3.14 otherwise at current versions there are warnings emitted. And for the if(IN_LIST) usage.
  • Duplicate CMake find module removed for simplicity
  • Added the Criterion::Criterion imported library to CMake find module so it can be linked to targets and provide usage requirements
  • Added pkg-config integration to the CMake find module
  • Find module code style synced with https://cmake.org/cmake/help/git-master/manual/cmake-developer.7.html

@petk petk force-pushed the patch-cmake-find-module branch from 39f5f1b to 46aeeac Compare December 27, 2024 01:13
@petk petk marked this pull request as draft December 27, 2024 18:18
- CMake minimum required version bumped to 3.14 otherwise at current
  versions there are warnings emitted. And for the `if(IN_LIST)` usage.
- Duplicate CMake find module removed for simplicity
- Added the `Criterion::Criterion` imported library to CMake find module
  so it can be linked to targets and provide usage requirements
- Added pkg-config integration to the CMake find module
- Find module code style synced with
  https://cmake.org/cmake/help/git-master/manual/cmake-developer.7.html
@petk petk force-pushed the patch-cmake-find-module branch from 46aeeac to 2470011 Compare December 27, 2024 21:45
@petk petk marked this pull request as ready for review December 27, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant