Feature: Laser firmware update modal #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izhen/Luban into feature/laser-firmware-update-modal
dohard-ma
requested review from
bbaa77770,
xiekun1992,
meiliang1123,
jane-rose and
wen-qing-255
jane-rose
approved these changes
Nov 30, 2021
src/app/ui/pages/Laser.jsx
Outdated
| @@ -9,7 +9,7 @@ import useSetState from '../../lib/hooks/set-state'; | |||
| import modal from '../../lib/modal'; | |||
| import LaserVisualizer from '../widgets/LaserVisualizer'; | |||
|
|
|||
| import { renderPopup, logPageView, useUnsavedTitle, renderModal } from '../utils'; | |||
| import { renderPopup, logPageView, useUnsavedTitle, renderModal, maxZindex } from '../utils'; | |||
There was a problem hiding this comment.
Set maxZindex as a constant
…er-firmware-update-modal' of github.com:MaShizhen/Luban into feature/laser-firmware-update-modal
wen-qing-255
approved these changes
Nov 30, 2021
|
@wen-qing-255 I had set the zindex of the highest level pop-up window to 100001000, 1000 larger than the Steps zindex |
xiekun1992
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LU-1856