Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix warning from anchor component #542

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Fix: Fix warning from anchor component #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be5f32
Fix: Fix warning from anchor component
jane-rose Nov 10, 2020
bca53a5
Refactor: Change draggable attribute to bool type on Anchot componnent
jane-rose Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/components/Anchor/AnchorUndraggable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class AnchorUndraggable extends PureComponent {
} = this.props;
const {
componentClass,
draggable = 'false',
draggable = false,
...props
} = this.props;
const Component = componentClass || 'a';
Expand Down
1 change: 0 additions & 1 deletion src/app/components/OptionalDropdown/OptionalDropdown.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const OptionalDropdown = (props) => {
<Anchor
onClick={onClick}
disabled={disabled}
draggable="false"
>
<i className={classNames(styles.icon, hidden ? styles['icon-unchecked'] : styles['icon-checked'])} />
<span>{title}</span>
Expand Down
1 change: 0 additions & 1 deletion src/app/containers/Header/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const Logo = memo(() => (
<Anchor
className="navbar-brand"
href="/#/workspace"
draggable='false'
title={`${settings.name} ${settings.version}`}
style={{ position: 'relative' }}
>
Expand Down
3 changes: 1 addition & 2 deletions src/app/widgets/CNCPath/ImageProcessMode.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class ImageProcessMode extends PureComponent {

return (
<React.Fragment>
<Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand} draggable="false">
<Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand}>
<span className="fa fa-arrows-alt sm-parameter-header__indicator" />
<span className="sm-parameter-header__title">{i18n._('Processing Mode')}</span>
<span className={classNames(
Expand All @@ -61,7 +61,6 @@ class ImageProcessMode extends PureComponent {
>
<div className={classNames(styles['laser-mode'], { [styles.selected]: this.props.mode === 'greyscale' })}>
<Anchor
draggable="false"
className={styles['laser-mode__btn']}
onClick={() => actions.changeSelectedModelMode('greyscale')}
>
Expand Down
1 change: 0 additions & 1 deletion src/app/widgets/CncLaserObjectList/ObjectListBox.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ class ObjectListBox extends PureComponent {
styles.name,
styles.bt
)}
draggable="false"
onClick={(event) => this.actions.onClickModelNameBox(model, event)}
>
<span
Expand Down
2 changes: 1 addition & 1 deletion src/app/widgets/CncLaserShared/Transformation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class Transformation extends PureComponent {
const actions = this.actions;
return (
<React.Fragment>
<Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand} draggable="false">
<Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand}>
<span className="fa fa-arrows-alt sm-parameter-header__indicator" />
<span className="sm-parameter-header__title">{i18n._('Transformation')}</span>
<span className={classNames(
Expand Down
6 changes: 2 additions & 4 deletions src/app/widgets/LaserParams/ImageProcessMode.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class ImageProcessMode extends PureComponent {

return (
<React.Fragment>
<Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand} draggable="false">
<Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand}>
<span className="fa fa-arrows-alt sm-parameter-header__indicator" />
<span className="sm-parameter-header__title">{i18n._('Processing Mode')}</span>
<span className={classNames(
Expand All @@ -64,7 +64,7 @@ class ImageProcessMode extends PureComponent {
<div className={styles['laser-modes']}>
<div className={classNames(styles['laser-mode'], { [styles.selected]: this.props.mode === 'bw' })}>
<Anchor
draggable="false"

disabled={disabled}
className={styles['laser-mode__btn']}
onClick={() => actions.changeSelectedModelMode('bw')}
Expand All @@ -75,7 +75,6 @@ class ImageProcessMode extends PureComponent {
</div>
<div className={classNames(styles['laser-mode'], { [styles.selected]: this.props.mode === 'greyscale' })}>
<Anchor
draggable="false"
disabled={disabled}
className={styles['laser-mode__btn']}
onClick={() => actions.changeSelectedModelMode('greyscale')}
Expand All @@ -86,7 +85,6 @@ class ImageProcessMode extends PureComponent {
</div>
<div className={classNames(styles['laser-mode'], { [styles.selected]: this.props.mode === 'vector' })}>
<Anchor
draggable="false"
disabled={disabled}
className={styles['laser-mode__btn']}
onClick={() => actions.changeSelectedModelMode('vector')}
Expand Down
1 change: 0 additions & 1 deletion src/app/widgets/PrintingMaterial/Material.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ class Material extends PureComponent {
<Anchor
key={option.value}
className={classNames(styles['material-btn'], { [styles.selected]: this.actions.isMaterialSelected(option) })}
draggable="false"
onClick={() => this.actions.onChangeMaterial(option.value)}
>
{i18n._(option.label)}
Expand Down
5 changes: 0 additions & 5 deletions src/app/widgets/PrintingVisualizer/VisualizerCameraOperations.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,31 +22,26 @@ class VisualizerCameraOperations extends PureComponent {
<React.Fragment>
<div style={{ display: 'inline-block', float: 'left' }}>
<Anchor
draggable="false"
className={classNames('fa', 'fa-chevron-left', styles['turn-left'])}
onClick={actions.toLeft}
/>
</div>
<div style={{ display: 'inline-block', float: 'left' }}>
<Anchor
draggable="false"
className={classNames('fa', 'fa-chevron-up', styles['turn-up'])}
onClick={actions.toTop}
/>
<Anchor
draggable="false"
className={classNames(styles['camera-reset'])}
onClick={actions.autoFocus}
/>
<Anchor
draggable="false"
className={classNames('fa', 'fa-chevron-down', styles['turn-down'])}
onClick={actions.toBottom}
/>
</div>
<div style={{ display: 'inline-block', float: 'left' }}>
<Anchor
draggable="false"
className={classNames('fa', 'fa-chevron-right', styles['turn-right'])}
onClick={actions.toRight}
/>
Expand Down