Fix: Allow sidebars to scroll independently of main window #552
Conversation
When the length of the sidebar exceeded that of the viewport, the body would scroll. This lead to unusual scroll behaviour in the console as both the console container and the main body would scroll at the same time. Resolve by fixing the height of the sidebars to 100% and allowing them to scroll if necessary. This means it is never necessary for the body to scroll and so the two scrolling areas now feel independent of each other. Closes Snapmaker#500
|
Nice try on the sidebar 😃 |
|
Ah ok. I had seen the primary sidebar but didn't realise it could go that large. |
|
Cool, nice try! I will send a pr to fix the bug. |
Widgets can be dragged between 2 bars. Seems like @jane-rose has found another issue here (relates to mouse event handling). |
|
Right ok. @jane-rose I am happy to carry on working on it if you want to point me in the direction you want to go. Otherwise the option to allow edits is also checked so feel free to make the changes yourself if you prefer. Thanks! |
|
#557. Thanks, u have to |
|
Great, shall I close this PR then in favour of the newer one? |
|
Definitely u can |
Had a go at resolving #500
There are a bunch of different ways of doing this kind of thing so I thought I'd suggest one and get some feedback.
This seemed like the least intrusive way of making the change but I'm happy to try again in a different way if someone can point me in the direction you'd prefer.