Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Disable generate gcode button when models are all hidden #580

Merged

Conversation

jane-rose
Copy link
Contributor

No description provided.

@jane-rose jane-rose added the Type: Improvement An improvement to a current feature label Nov 24, 2020
@@ -189,6 +189,10 @@ class ModelGroup extends EventEmitter {
return this.selectedModelArray.length === 1 && this.selectedModelArray[0].changeShowOrigin();
}

isModelNotHidden() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasModelVisible or hasModelNotHidden?

@parachvte parachvte merged commit 6e8128e into Snapmaker:master Nov 30, 2020
@jane-rose jane-rose deleted the improve-disable-generate-gcode-button branch December 21, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement An improvement to a current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants