Improvement: Limit scale value in 3DP to avoid object dimension setting to 0 #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parachvte
reviewed
Nov 29, 2020
parachvte
reviewed
Nov 29, 2020
| || parentEVec.y * meshObject.scale.y < 0.01 | ||
| || parentEVec.z * meshObject.scale.z < 0.01 | ||
| ) { | ||
| shouldDisableScale = true; |
There was a problem hiding this comment.
inside 'forEach' can't use break or return, i change it to 'every'
There was a problem hiding this comment.
You can return the value of Array.every()
shouldApplyScaleToObjects(parentEVec) {
return this.object.children.every((meshObject) => {
if (condition) {
return false; // should disable
}
return true;
});
}
parachvte
reviewed
Nov 29, 2020
parachvte
reviewed
Nov 29, 2020
jane-rose
force-pushed
the
improve-to-limit-the-scale-value
branch
from
7ba0712 to
8ee1c9a
Compare
jane-rose
force-pushed
the
improve-to-limit-the-scale-value
branch
from
8ee1c9a to
e8b7b0e
Compare
parachvte
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.