Fix: Fix connecting wifi manually bug #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #640 |
parachvte
requested changes
Jan 7, 2021
| @@ -192,6 +193,7 @@ class WifiConnection extends PureComponent { | |||
|
|
|||
| this.props.setManualIP(text); | |||
| const server = new Server('Manual', text); | |||
| this.props.addSelectedServerToList(server); | |||
There was a problem hiding this comment.
Note that we only support one single manual server (cause we only save one).
So everytime we call setSelectedServer(), the server must be added to server list.
=> addSelectedServerToList() action is not necessary, the logic can be put inside of setSelectedServer().
There was a problem hiding this comment.
No, i konw think so.
| @@ -41,6 +41,22 @@ const setSelectedServer = (server) => (dispatch) => { | |||
| dispatch(baseActions.updateState({ server })); | |||
| }; | |||
|
|
|||
| const addSelectedServerToList = (server) => (dispatch, getState) => { | |||
There was a problem hiding this comment.
The action will cause only server present in servers, but what we need is prepend selected server to server list, not replacing it.
There was a problem hiding this comment.
Yep, that's make sense
jane-rose
force-pushed
the
fix-connecting-wifi-manually-bug
branch
from
f9c900a to
c727a03
Compare
parachvte
pushed a commit
that referenced
this pull request
Jan 11, 2021
parachvte
pushed a commit
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.