Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to sqlite #42

Merged
merged 5 commits into from
Aug 2, 2023
Merged

migrate to sqlite #42

merged 5 commits into from
Aug 2, 2023

Conversation

ajskateboarder
Copy link
Contributor

@ajskateboarder ajskateboarder commented Aug 1, 2023

Personally Supabase is a little overkill for what is basically a key value store for Snazzle. SQLite is much better for this

I also fixed Scratch Auth so that it redirects and authenticates correctly (it wasn't doing that before)

Somebody should also test if it works on Replit

Fixes #39 🚀🚀🚀🚀🚀🚀

@redstone-dev
Copy link
Collaborator

Oh thank you!! Will merge when I get back from where I'm going

@redstone-dev
Copy link
Collaborator

Screw it, ima fix the merge conflicts now

Screw family bonding time (jk)

@redstone-dev
Copy link
Collaborator

Actually nvm, we just merged #44, so I think this is kind of... I can't find the word but like unneeded??

I'll hold it to a vote, it seems wrong to have just me merging this after merging #44...

Sorry about that.

@davidtheplatform
Copy link
Contributor

Also @ajskateboarder your autoformatter deleted a bunch of stuff and I think you committed files in the .gitignore

If we do end up migrating to SQLite it should be in a different PR

@ajskateboarder
Copy link
Contributor Author

ajskateboarder commented Aug 2, 2023

Actually nvm, we just merged #44, so I think this is kind of... I can't find the word but like unneeded??
I'll hold it to a vote, it seems wrong to have just me merging this after merging #44...

I'll see what I can do. I personally think SQLite is much easier to use, and Python even supports out of the box
Forgot to also mention that I made some QOL changes to the scratch-auth functions (silly me always forgetting what changes i made)

Also @ajskateboarder your autoformatter deleted a bunch of stuff and I think you committed files in the .gitignore

Oh whoops I use super opinionated stuff for Python, I'll remove the vscode config

@redstone-dev
Copy link
Collaborator

lgtm

@redstone-dev redstone-dev merged commit d8ce29a into SnarpleDev:main Aug 2, 2023
@davidtheplatform
Copy link
Contributor

davidtheplatform commented Aug 2, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to SQLite
3 participants