Restructure work - clear up site conditions vs site location

[micah-prime]

We now have a Site belonging to a Campaign. Previously SiteData had a date AND location associated with weather, conditions, etc.

To maintain this info, we can change SiteData to SiteConditions and link that to the Site.

https://github.com/SnowEx/snowexsql/blob/dev/snowexsql/tables/site_data.py#L11
https://github.com/SnowEx/snowexsql/blob/dev/snowexsql/tables/site.py#L20

Site can have the location and SiteConditions can have date-specific conditions. Each point or pit can link to a SiteCondition, belonging to a Site, belonging to a Campaign.

FYI @micahjohnson150

[jomey]

erDiagram
  Campaign ||--|{ Site : "has many"
  Site ||--|| SiteCondition : "has one"
  Campaign
  Site {
    int campaign_id
    int site_condition_id
    String plot_id
    date site_visit
  }
  SiteCondition {
    int site_id
  }

Loading

[jomey]

I imagine all of these pit header fields going into the Site table

[micah-prime]

I imagine all of these pit header fields going into the Site table

Yep, basically everything here https://github.com/SnowEx/snowexsql/blob/master/snowexsql/tables/site_data.py#L15-L28

[micah-prime]

So I was initially under the impression that a site would not be date dependent unlike the pits. This was a misconception on my part.
Since Site == a pit, does it still make sense to split up the site condition into a separate table, or should we just keep the site conditions in the Site table?
@jomey

[jomey]

So I was initially under the impression that a site would not be date dependent unlike the pits. This was a misconception on my part. Since Site == a pit, does it still make sense to split up the site condition into a separate table, or should we just keep the site conditions in the Site table? @jomey

I guess we can keep these as attributes in the table. Can't think of a obvious reason and we can come back to this if needed.
Think the overview here seems to be the target for now.

[micah-prime]

Sweet, I'll just consolidate for now then