Parallelize table generation #203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-cnivera
commented
Oct 30, 2024
| fqn_table = create_fqn_table(table) | ||
| fqn_databse_schema = f"{fqn_table.database}.{fqn_table.schema_name}" | ||
|
|
||
| if fqn_databse_schema not in unique_database_schema: |
There was a problem hiding this comment.
I don't think we were using unique_database_schema anywhere, so I removed it
sfc-gh-cnivera
requested review from
sfc-gh-rehuang and
sfc-gh-jsummer
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating getting this working in SiS
When generating a semantic model, we currently iterate through all of the tables that the user has specified and generate a representation for each. This is done sequentially, which leads to long latencies. This PR parallelizes the table generation which drastically reduces generation time.
For example, here are the generation times for a large semantic model containing 20 tables from
COVID19_EPIDEMIOLOGICAL_DATA.Sequential processing:
Concurrent processing: