Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]: snowflake_grant_ownership example gives an incorrect key word - "plural_object_type" instead of "object_type_plural" #2696

Closed
cpmub1 opened this issue Apr 11, 2024 · 4 comments
Closed

[Docs]: snowflake_grant_ownership example gives an incorrect key word - "plural_object_type" instead of "object_type_plural" #2696

cpmub1 opened this issue Apr 11, 2024 · 4 comments
Assignees
@sfc-gh-jcieslak
Labels
category:documentation docs Used to mark issues with documentation remark/questions resource:grant_ownership Issue connected to the snowflake_grant_ownership resource

Comments

@cpmub1
Copy link

cpmub1 commented Apr 11, 2024

Documentation Link

https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/grant_ownership

Description

snowflake_grant_ownership example gives an incorrect key word - "plural_object_type" instead of "object_type_plural"

References

No response

Would you like to implement a fix?

None
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @cpmub1
Thanks for pointing this out. We'll try to address this as soon as possible.

@sfc-gh-jcieslak sfc-gh-jcieslak self-assigned this Apr 11, 2024
@sfc-gh-jcieslak sfc-gh-jcieslak added the docs Used to mark issues with documentation remark/questions label Apr 11, 2024
@sfc-gh-jcieslak sfc-gh-jcieslak mentioned this issue Apr 11, 2024
Merged
sfc-gh-jcieslak added a commit that referenced this issue Apr 17, 2024
@sfc-gh-jcieslak
feat: Update target objects for privilege-granting resources (#2688)
74e2b6b 
A follow-up for
#2604 (comment).
Updated target objects for privilege-granting resources based on
documentation (also added references above available object's list).

Pr also contains:
- #2689 is fixed in the pr and acceptance tests are added. 
- #2696 documentation fix
@sfc-gh-jcieslak
Copy link
Collaborator

Hey, we released a new provider version: https://github.com/Snowflake-Labs/terraform-provider-snowflake/releases/tag/v0.89.0. The docs should be fixed now.

@sfc-gh-jcieslak sfc-gh-jcieslak added resource:grant_ownership Issue connected to the snowflake_grant_ownership resource category:documentation labels May 20, 2024
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @cpmub1
Did you have a chance to take a look at the fixed documentation? We would like you to confirm the change and close the ticket if that's what you wanted to see.

@cpmub1
Copy link
Author

cpmub1 commented May 29, 2024

this is looking good now. thanks for fixing it

@cpmub1 cpmub1 closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-jcieslak sfc-gh-jcieslak

Labels
category:documentation docs Used to mark issues with documentation remark/questions resource:grant_ownership Issue connected to the snowflake_grant_ownership resource
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpmub1 @sfc-gh-jcieslak