Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Validations cleanup and old grants removal #2884

Merged
merged 10 commits into from
Jun 21, 2024
Merged

chore: Validations cleanup and old grants removal #2884

merged 10 commits into from
Jun 21, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Jun 21, 2024 •
edited
Loading

  • Remove the following validations (adjust the documentation to link valid input formats for fields like passwords or account names):
    • ValidatePassword
    • ValidateIsNotAccountLocator
    • ValidateAccountIdentifier
    • ValidateEmail
    • ValidateAdminName
    • ValidateIdentifier
  • implement IsValidAccountIdentifier(replacement for ValidateIsNotAccountLocator)
  • replace ValidateAccountIdentifier with already existing IsValidIdentifier[sdk.AccountObjectIdentifier]()
  • extract csv-based identifier parsing logic (with tests)
  • fix tests using Errorf check (probably more to follow in other PR)
  • resolve TODO with grant ownership
  • remove old grant resources from [❄️ Snowflake Official] The removal of deprecated grant resources #2736
  • remove old ownership resources
  • add new issue to the known issues list
  • remove preview resource from all grant resources

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review June 21, 2024 13:27
sfc-gh-jmichalak
sfc-gh-jmichalak reviewed Jun 21, 2024
View reviewed changes
pkg/validation/validation.go Outdated Show resolved Hide resolved
pkg/resources/account.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for ad6036147301f29d228c1ded618b74401d753cfc

sfc-gh-jcieslak
sfc-gh-jcieslak reviewed Jun 21, 2024
View reviewed changes
examples/resources/snowflake_role_grants/import.sh Show resolved Hide resolved
pkg/helpers/helpers.go Outdated Show resolved Hide resolved
pkg/helpers/helpers.go Outdated Show resolved Hide resolved
pkg/helpers/identifier_string_parser_test.go Show resolved Hide resolved
pkg/resources/account.go Show resolved Hide resolved
pkg/resources/validators_test.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for 726f6c0d3487b1869453ee9f2dadb8865d6e97fb

@sfc-gh-asawicki sfc-gh-asawicki merged commit 05b7eee into main Jun 21, 2024
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the validations-cleanup branch June 21, 2024 15:56
@snowflake-release-please snowflake-release-please bot mentioned this pull request Jun 21, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Jul 10, 2024
@snowflake-release-please
chore(main): release 0.93.0 (#2866)
ad74736 
🤖 I have created a release *beep* *boop*
---


##
[0.93.0](v0.92.0...v0.93.0)
(2024-07-10)


### 🎉 **What's new:**

* Add OAUTH integration for custom clients
([#2908](#2908))
([d9b557f](d9b557f))
* Add oauth integration for partner applications
([#2912](#2912))
([91788e5](91788e5))
* Add support for cortex search service
([#2860](#2860))
([43aa89f](43aa89f))
* API Authentication integration v1 readiness
([#2898](#2898))
([91931da](91931da))
* External Oauth integration v1 readiness
([#2907](#2907))
([ed237c3](ed237c3))
* Generate show outputs with mappers
([#2886](#2886))
([1cada88](1cada88))
* Introduce security integrations datasource
([#2892](#2892))
([7f6c657](7f6c657))
* SAML2 integration v1 readiness
([#2868](#2868))
([d0c136d](d0c136d))
* SCIM integration v1 readiness
([#2846](#2846))
([269df6b](269df6b))
* Security integrations datasource v1 readiness
([#2913](#2913))
([d10474a](d10474a))
* standard database v1 readiness
([#2842](#2842))
([3c11953](3c11953))
* Warehouse redesign final touches
([#2900](#2900))
([0eab636](0eab636))
* Warehouse redesign part1
([#2864](#2864))
([6664457](6664457))
* Warehouse redesign part2
([#2887](#2887))
([1aaf417](1aaf417))
* Warehouse redesign part3
([#2890](#2890))
([873a1ed](873a1ed))
* Warehouse redesign part4
([#2893](#2893))
([d525fd9](d525fd9))


### 🔧 **Misc**

* Add documentation on unset and defaults
([#2882](#2882))
([85a7836](85a7836))
* apply minor database changes
([#2872](#2872))
([6ccac59](6ccac59))
* Apply new resource conventions to scim integration
([#2891](#2891))
([e11e608](e11e608))
* Improve generator template organization
([#2820](#2820))
([5035e2f](5035e2f))
* Nuke stale objects
([#2869](#2869))
([9c4a117](9c4a117))
* Show a possible solution for
[#2877](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2877)
([#2878](#2878))
([6fb437b](6fb437b))
* Validations cleanup and old grants removal
([#2884](#2884))
([05b7eee](05b7eee))


### 🐛 **Bug fixes:**

* Add disclaimers and fix tests
([#2905](#2905))
([1deaedc](1deaedc))
* Fix cortex search service
([#2904](#2904))
([763d06c](763d06c))
* use suppressQuoting to fix stage file_format permadiff
([#2885](#2885))
([fd70f6e](fd70f6e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-asawicki @sfc-gh-jcieslak @sfc-gh-jmichalak