feat: Add OAUTH integration for custom clients #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jcieslak
force-pushed
the
oauth-for-custom-clients-v1
branch
from
b5fd03e
to
c7ce026
Compare
|
Integration tests failure for b5fd03e439920a661bf634f2c82bd33276ba835a |
|
Integration tests failure for c7ce02688b8e4bed794e7d154382ccfe1c6ada5c |
sfc-gh-asawicki
requested changes
Jul 4, 2024
pkg/resources/testdata/TestAcc_OauthIntegrationForCustomClients/complete/test.tf
Outdated
Show resolved
Hide resolved
pkg/resources/oauth_integration_for_custom_clients_acceptance_test.go
Outdated
Show resolved
Hide resolved
pkg/resources/oauth_integration_for_custom_clients_acceptance_test.go
Outdated
Show resolved
Hide resolved
sfc-gh-jmichalak
requested changes
Jul 4, 2024
pkg/resources/testdata/TestAcc_OauthIntegrationForCustomClients/complete/test.tf
Outdated
Show resolved
Hide resolved
# Conflicts: # docs/index.md # examples/additional/deprecated_resources.MD # pkg/acceptance/helpers/random/certs.go # pkg/acceptance/importchecks/import_checks.go # pkg/sdk/testint/security_integrations_gen_integration_test.go
sfc-gh-jcieslak
commented
Jul 5, 2024
examples/resources/snowflake_oauth_integration_for_custom_clients/resource.tf
Outdated
Show resolved
Hide resolved
sfc-gh-jcieslak
force-pushed
the
oauth-for-custom-clients-v1
branch
from
9989374
to
d239eb7
Compare
|
Integration tests failure for 998937494227471ed9b0e6b3e8efe85b27a0b4b4 |
sfc-gh-jcieslak
force-pushed
the
oauth-for-custom-clients-v1
branch
from
d239eb7
to
a9bc700
Compare
|
Integration tests failure for d239eb70f60bbd1ca9f4fe38479b5159ec798724 |
|
Integration tests failure for a9bc7006e1b5bf6ea183d39b091ce10c16255e3d |
|
Integration tests failure for 73805dcf658a4cb98ff9959e8ac59d48cfbed7c0 |
sfc-gh-asawicki
previously approved these changes
Jul 8, 2024
sfc-gh-jmichalak
previously approved these changes
Jul 9, 2024
# Conflicts: # MIGRATION_GUIDE.md # pkg/provider/provider.go
sfc-gh-jcieslak
dismissed stale reviews from sfc-gh-jmichalak and sfc-gh-asawicki
via
2f9bb42
|
Integration tests cancelled for 2f9bb42ed1b3212650fe74ad90aa7497fddf299b |
sfc-gh-jmichalak
approved these changes
Jul 9, 2024
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jul 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.93.0](v0.92.0...v0.93.0) (2024-07-10) ### 🎉 **What's new:** * Add OAUTH integration for custom clients ([#2908](#2908)) ([d9b557f](d9b557f)) * Add oauth integration for partner applications ([#2912](#2912)) ([91788e5](91788e5)) * Add support for cortex search service ([#2860](#2860)) ([43aa89f](43aa89f)) * API Authentication integration v1 readiness ([#2898](#2898)) ([91931da](91931da)) * External Oauth integration v1 readiness ([#2907](#2907)) ([ed237c3](ed237c3)) * Generate show outputs with mappers ([#2886](#2886)) ([1cada88](1cada88)) * Introduce security integrations datasource ([#2892](#2892)) ([7f6c657](7f6c657)) * SAML2 integration v1 readiness ([#2868](#2868)) ([d0c136d](d0c136d)) * SCIM integration v1 readiness ([#2846](#2846)) ([269df6b](269df6b)) * Security integrations datasource v1 readiness ([#2913](#2913)) ([d10474a](d10474a)) * standard database v1 readiness ([#2842](#2842)) ([3c11953](3c11953)) * Warehouse redesign final touches ([#2900](#2900)) ([0eab636](0eab636)) * Warehouse redesign part1 ([#2864](#2864)) ([6664457](6664457)) * Warehouse redesign part2 ([#2887](#2887)) ([1aaf417](1aaf417)) * Warehouse redesign part3 ([#2890](#2890)) ([873a1ed](873a1ed)) * Warehouse redesign part4 ([#2893](#2893)) ([d525fd9](d525fd9)) ### 🔧 **Misc** * Add documentation on unset and defaults ([#2882](#2882)) ([85a7836](85a7836)) * apply minor database changes ([#2872](#2872)) ([6ccac59](6ccac59)) * Apply new resource conventions to scim integration ([#2891](#2891)) ([e11e608](e11e608)) * Improve generator template organization ([#2820](#2820)) ([5035e2f](5035e2f)) * Nuke stale objects ([#2869](#2869)) ([9c4a117](9c4a117)) * Show a possible solution for [#2877](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2877) ([#2878](#2878)) ([6fb437b](6fb437b)) * Validations cleanup and old grants removal ([#2884](#2884)) ([05b7eee](05b7eee)) ### 🐛 **Bug fixes:** * Add disclaimers and fix tests ([#2905](#2905)) ([1deaedc](1deaedc)) * Fix cortex search service ([#2904](#2904)) ([763d06c](763d06c)) * use suppressQuoting to fix stage file_format permadiff ([#2885](#2885)) ([fd70f6e](fd70f6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
oauth_client_rsa_public_keyandoauth_client_rsa_public_key_2are strange fields because they don't have any value returned by the SHOW or DESC, so the only diff is applied by the TF (because those fields are not set in the read operation). Currently, tests show they work, so I left them this way.