Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix parameters datasource acceptance test #1749

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

sfc-gh-ngaberel
Copy link
Contributor

@sfc-gh-ngaberel sfc-gh-ngaberel commented Apr 24, 2023

The value field can sometime be null. Recently the first parameters returned has changed and that new parameter has a null value. We'll stop relying on the value field being set for acceptance tests.

@github-actions
Copy link

Integration tests failure for 8854db8fd61694857679dccf7bf443f28c4a9e43

1 similar comment
@github-actions
Copy link

Integration tests failure for 8854db8fd61694857679dccf7bf443f28c4a9e43

@github-actions
Copy link

Integration tests success for 78917c616580da72ad149ea1cf7229d61ea15e9f

@sfc-gh-ngaberel sfc-gh-ngaberel marked this pull request as ready for review April 24, 2023 20:17
@sfc-gh-ngaberel sfc-gh-ngaberel merged commit 338a19d into main Apr 24, 2023
@sfc-gh-ngaberel sfc-gh-ngaberel deleted the fix-parameters-test branch April 24, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants