Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate application role to new sdk #2149

Merged
merged 17 commits into from
Nov 2, 2023
Merged

feat: Migrate application role to new sdk #2149

merged 17 commits into from
Nov 2, 2023

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Oct 24, 2023 •
edited
Loading

As discussed I've migrated application roles with only querying capabilities. I've tried to describe the reason behind incompleteness of ApplicationRoles interface and also I've described the integration test function (mostly I've described what is going in the setup of the test, because it's pretty unusual and some knowledge about native apps is required). Some of the things were left from the previous change (with create, alter, etc.), mostly generator stuff like

  • Grant, Revoke operations added to the generator (they're pretty common and they were tested on the previous version
  • keyword builders for numbers and common in SHOW operations LimitFrom

Test Plan

  • integration tests
  • unit tests

References

A short tutorial on creating native app in Snowflake
SHOW APPLICATION ROLES

github-actions[bot]
github-actions bot reviewed Oct 24, 2023
View reviewed changes
pkg/sdk/application_roles_def.go Outdated Show resolved Hide resolved
pkg/sdk/application_roles_dto_gen.go Outdated Show resolved Hide resolved
pkg/sdk/application_roles_impl_gen.go Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for e9b124ee4a971e1a484c730abbe2d1bbe30303ab

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-application-role-to-new-sdk branch from e9b124e to 20b41e8 Compare October 24, 2023 13:48
@sfc-gh-jcieslak sfc-gh-jcieslak changed the title Migrate application role to new sdk feat: Migrate application role to new sdk Oct 24, 2023
@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review October 24, 2023 13:52
@github-actions
Copy link

Integration tests failure for 20b41e8e1dfb9021d16437163c42b9dfa33fa092

sfc-gh-asawicki
sfc-gh-asawicki requested changes Oct 25, 2023
View reviewed changes
pkg/sdk/testint/test-resources/setup.sql Outdated Show resolved Hide resolved
pkg/sdk/testint/test-resources/manifest.yml Outdated Show resolved Hide resolved
pkg/sdk/testint/application_roles_gen_integration_test.go Outdated Show resolved Hide resolved
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-application-role-to-new-sdk branch from 20b41e8 to 8b75e22 Compare October 26, 2023 12:06
@github-actions
Copy link

Integration tests failure for 8b75e229416f9d135db4daf21f8e1d9496932ab7

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-application-role-to-new-sdk branch 2 times, most recently from 4526e04 to 227c427 Compare October 30, 2023 08:33
@github-actions
Copy link

Integration tests failure for 4526e04daea64e45748e3cdda72ec0bc2888c7eb

@github-actions
Copy link

Integration tests failure for 227c4278d607e55b5db539c6b7eeb05f6ac62c14

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review October 30, 2023 12:07
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-application-role-to-new-sdk branch from 227c427 to 4835aca Compare October 30, 2023 12:38
@github-actions
Copy link

Integration tests failure for 4835acad1bf277695649897693beb6e3b1a21883

3 similar comments
@github-actions
Copy link

Integration tests failure for 4835acad1bf277695649897693beb6e3b1a21883

@github-actions
Copy link

Integration tests failure for 4835acad1bf277695649897693beb6e3b1a21883

@github-actions
Copy link

Integration tests failure for 4835acad1bf277695649897693beb6e3b1a21883

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the migrate-application-role-to-new-sdk branch from 4835aca to bda9b74 Compare November 2, 2023 11:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Integration tests failure for bda9b74fb8be666924499c3f7e4e4f2394a6c3b2

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Integration tests failure for b880e08904ef741ccbbf137d55535792ae136619

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 7abb4db into main Nov 2, 2023
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the migrate-application-role-to-new-sdk branch November 2, 2023 16:02
@snowflake-release-please snowflake-release-please bot mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jcieslak @sfc-gh-asawicki