Create token #29
Merged
Create token #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgeddes
reviewed
May 29, 2023
Base automatically changed from
alistair/statemine-reserve-location
to
snowbridge
May 30, 2023 13:35
alistair-singh
force-pushed
the
alistair/create-token
branch
2 times, most recently
from
806a918
to
6d2a076
Compare
alistair-singh
force-pushed
the
alistair/create-token
branch
3 times, most recently
from
cbb944c
to
c7335cf
Compare
vgeddes
reviewed
Jun 22, 2023
vgeddes
reviewed
Jun 22, 2023
alistair-singh
force-pushed
the
alistair/create-token
branch
from
41987d3
to
35a6e41
Compare
This reverts commit a4d5433.
vgeddes
reviewed
Jun 23, 2023
| @@ -522,16 +527,26 @@ pub mod bridging { | |||
| use xcm_builder::UnpaidRemoteExporter; | |||
|
|
|||
| parameter_types! { | |||
| pub BridgeHubKusamaParaId: u32 = 1002; | |||
| pub BridgeHubKusamaParaId: u32 = 1013; | |||
There was a problem hiding this comment.
Fine for now - but obviously we can't merge this into upstream cumulus. So we'll need to either introduce a new asset-hub runtime for rococo or change our bridge hub ParaId
vgeddes
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowbridge Companion: Snowfork/snowbridge#846
Resolves: SNO-490