Contracts V3 #50
Merged
Contracts V3 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
commented
Jul 24, 2023
| @@ -386,7 +384,7 @@ impl ExportXcm for BridgeHubRococoOrBridgeHubWococoSwitchExporter { | |||
| destination, | |||
| message, | |||
| ) | |||
| .map(|result| ((EthereumNetwork::get(), result.0), result.1)) | |||
| .map(|result| ((EthereumNetwork::get(), (result.0, XcmHash::default())), result.1)) | |||
There was a problem hiding this comment.
Because SnowbridgeExporter::validate no longer returns the XcmHash. Not sure what the solution is here, I think @vgeddes mentioned in a newer version of Substrate the other validators also do not return the XcmHash?
There was a problem hiding this comment.
Yeah returning XcmHash::default is fine here.
When we upgrade to the latest cumulus it will all be fine.
claravanstaden
commented
Jul 24, 2023
|
@claravanstaden Actually, you should merge this PR into the |
claravanstaden
force-pushed
the
clara/proxy-contracts-fix-cumulus
branch
from
6ae081f
to
85da228
Compare
alistair-singh
approved these changes
Jul 25, 2023
vgeddes
approved these changes
Jul 25, 2023
vgeddes
added a commit
that referenced
this pull request
Jul 30, 2023
* Fix cumulus builds * Update cumulus (#46) * Create Agent (#47) * add hashed description * use existing account * add call filter * Create Agent (#48) * initial * update cargo lock * handle local accounts and pallets * Add set_gateway to safe call filter (#49) * Fix cumulus bridgehub runtime for proxy contracts. (#50) Co-authored-by: claravanstaden <Cats 4 life!> * Update inbound queue benchmarks. (#51) * Update inbound queue benchmarks. * Update inbound queue benchmarks. --------- Co-authored-by: claravanstaden <Cats 4 life!> * Asset transfer (#52) * update registry to gateway * added agent config * ws * increase message size --------- Co-authored-by: David Dunn <26876072+doubledup@users.noreply.github.com> Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
alistair-singh
added a commit
that referenced
this pull request
Jul 30, 2023
* Fix cumulus builds * Update cumulus (#46) * Create Agent (#47) * add hashed description * use existing account * add call filter * Create Agent (#48) * initial * update cargo lock * handle local accounts and pallets * Add set_gateway to safe call filter (#49) * Fix cumulus bridgehub runtime for proxy contracts. (#50) Co-authored-by: claravanstaden <Cats 4 life!> * Update inbound queue benchmarks. (#51) * Update inbound queue benchmarks. * Update inbound queue benchmarks. --------- Co-authored-by: claravanstaden <Cats 4 life!> * Asset transfer (#52) * update registry to gateway * added agent config * ws * increase message size * added weights --------- Co-authored-by: David Dunn <26876072+doubledup@users.noreply.github.com> Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowbridge companion: Snowfork/snowbridge#882