This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Extract Ethereum chain id in tests #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 23, 2024 09:18
claravanstaden
commented
Feb 26, 2024
Comment on lines
+56
to
+67
| [workspace.dependencies] | ||
| polkavm-linker = "0.8.2" | ||
| polkavm-derive = "0.8.0" | ||
| log = { version = "0.4.20", default-features = false } | ||
| quote = { version = "1.0.33" } | ||
| serde = { version = "1.0.197", default-features = false } | ||
| serde-big-array = { version = "0.3.2" } | ||
| serde_derive = { version = "1.0.117" } | ||
| serde_json = { version = "1.0.114", default-features = false } | ||
| serde_yaml = { version = "0.9" } | ||
| syn = { version = "2.0.50" } | ||
| thiserror = { version = "1.0.48" } |
There was a problem hiding this comment.
Includes workspace dependencies, which was added upstream in the polkadot-sdk/Cargo.toml. I first deleted our Cargo.toml in this directory, but then running just the Snowbridge tests in CI becomes a pain, so I thought this duplication is OK.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding runtime tests to polkadot-fellows/runtimes#130, I noticed the Ethereum chain ID is hardcoded in the test helpers and cannot be updated to chain id =
1in the Kusama and Polkadot runtimes.