This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently for sending Ethereum asset by
reserve_transfer_assets
to work it requires to explicitly set xcm version of Ethereum Location on Assethub, e.g.polkadot-sdk/cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/snowbridge.rs
Lines 391 to 394 in 68ab248
Actually this is unnessessary, IMO setting xcm version of Ethereum only make sense on BridgeHub to construct different
Command
to execute on Ethereum when there is xcm version specific logic on solidity side.It seems more like a bug introduced by
bridge-hub-router
, more details in #140 (comment)