Sync beacon execution update on demand #1140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrong
commented
Feb 6, 2024
| @@ -330,32 +325,11 @@ pub mod pallet { | |||
| } | |||
|
|
|||
| pub(crate) fn process_update(update: &Update) -> DispatchResult { | |||
| Self::cross_check_execution_state()?; | |||
There was a problem hiding this comment.
Remove the cross_check we don't need it any more.
yrong
commented
Feb 6, 2024
Comment on lines
-551
to
-559
| // Checks that we don't skip execution headers, they need to be imported sequentially. | ||
| let latest_execution_state: ExecutionHeaderState = Self::latest_execution_state(); | ||
| ensure!( | ||
| latest_execution_state.block_number == 0 || | ||
| update.execution_header.block_number() == | ||
| latest_execution_state.block_number + 1, | ||
| Error::<T>::ExecutionHeaderSkippedBlock | ||
| ); | ||
|
|
There was a problem hiding this comment.
Remove the consecutive check we don't need it any more.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
===========================================
+ Coverage 49.66% 72.17% +22.51%
===========================================
Files 63 57 -6
Lines 3707 2523 -1184
Branches 72 72
===========================================
- Hits 1841 1821 -20
+ Misses 1849 685 -1164
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: SNO-805,SNO-428
Addressing: paritytech/polkadot-sdk#2522 (comment)
It depends on EIP-4788 which requires Dencun to be activated first so mark it as
do-not-merge.