Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query the status of a single transfer & add comments for the indexer api #1370

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Query the status of a single transfer & add comments for the indexer api #1370

merged 5 commits into from
Feb 3, 2025

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Jan 26, 2025 •
edited
Loading

@yrong yrong marked this pull request as ready for review January 26, 2025 15:54
@yrong yrong requested a review from alistair-singh January 30, 2025 08:27
alistair-singh
alistair-singh reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But we are missing one method and example, how to query the status of a single bridge transfer via message id.

@yrong yrong mentioned this pull request Jan 31, 2025
Merged
@yrong
Copy link
Contributor Author

yrong commented Jan 31, 2025

we are missing one method and example, how to query the status of a single bridge transfer via message id.

Addressed in d341b69

@yrong yrong changed the title Add comments for the indexer api Query the status of a single transfer & add comments for the indexer api Jan 31, 2025
@yrong yrong requested a review from alistair-singh January 31, 2025 15:07
@yrong yrong merged commit 38bcf47 into main Feb 3, 2025
1 check passed
@yrong yrong deleted the ron/comments-for-indexer branch February 3, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair-singh alistair-singh alistair-singh approved these changes

Assignees
No one assigned
Labels
Component: Web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yrong @alistair-singh