Improve beefy tests

[yrong]

Resolves: SNO-576

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (proxy-contracts@a2c96f8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@                Coverage Diff                 @@
##             proxy-contracts     #901   +/-   ##
==================================================
  Coverage                   ?   68.43%           
==================================================
  Files                      ?       42           
  Lines                      ?     1774           
  Branches                   ?       72           
==================================================
  Hits                       ?     1214           
  Misses                     ?      541           
  Partials                   ?       19           

Flag	Coverage Δ
solidity	73.31% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yrong]

Gas consumed increased as we change test more close to real workflow(e.g. add createFinalBitfield in each test) and not a issue.

testSubmitWithHandoverFailWithoutPrevRandao() (gas: -2264 (-0.405%))
testSubmitFailWithoutPrevRandao() (gas: -2177 (-0.407%))
testSubmitFailForPrevRandaoTooEarlyOrTooLate() (gas: -1450 (-0.690%))
testSubmitFailForPrevRandaoCapturedMoreThanOnce() (gas: -1959 (-0.727%))
testScaleEncodeCommit() (gas: 281 (0.872%))
testSubmitWithHandoverFailStaleCommitment() (gas: 79700 (10.195%))
testSubmitWithHandover() (gas: 68945 (10.315%))
testSubmitFailWithStaleCommitment() (gas: 79563 (10.499%))
testSubmitFailInvalidSignature() (gas: 76694 (13.187%))
testSubmitFailWithInvalidBitfield() (gas: 76222 (13.628%))
testSubmitFailValidatorNotInBitfield() (gas: 77562 (13.640%))
Overall gas change: 451117 (8.166%)

[vgeddes]

Looks good. Let's merge this in.

I added comments about the next task, once you've merged in.

[vgeddes]

Next steps - to implement in a new ticket - let's move this script and helpers.ts to a new package under core/packages. We can call the package test-helpers or something like that.

The goal is to remove javascript stuff from the contracts project.

[vgeddes]

We should add a new package under core/packages with our contract bindings. Can call the package directory contract-types, and the package name @snowbridge/contract-types.

You'll need to include this script command in the new package:

snowbridge/core/packages/contracts/package.json

Line 16 in d26678d

"build:types": "typechain --target ethers-v5 'out/**/!(*.t|test).sol/!(*.abi).json' --out-dir types",

Then this dependency should change to:

import type { BeefyClient } from "@snowbridge/contract-types"