Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update inbound queue benchmarks. #902

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Update inbound queue benchmarks. #902

merged 6 commits into from
Jul 26, 2023

Conversation

claravanstaden
Copy link
Contributor

@claravanstaden claravanstaden commented Jul 25, 2023 •
edited
Loading

Updates inbound queue benchmarks after proxy contract changes.

Cumulus companion: Snowfork/cumulus#51

Resolves: SNO-570

@claravanstaden claravanstaden mentioned this pull request Jul 25, 2023
Merged
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (proxy-contracts@50ea024). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 947448e differs from pull request most recent head 788ec40. Consider uploading reports for the commit 788ec40 to get more accurate results

Additional details and impacted files 
@@                Coverage Diff                 @@
##             proxy-contracts     #902   +/-   ##
==================================================
  Coverage                   ?   68.43%           
==================================================
  Files                      ?       42           
  Lines                      ?     1774           
  Branches                   ?       72           
==================================================
  Hits                       ?     1214           
  Misses                     ?      541           
  Partials                   ?       19
Flag Coverage Δ
rust 67.27% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claravanstaden claravanstaden marked this pull request as ready for review July 25, 2023 18:24
vgeddes
vgeddes approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

yrong
yrong approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@claravanstaden claravanstaden merged commit eaa9eee into proxy-contracts Jul 26, 2023
4 checks passed
@claravanstaden claravanstaden deleted the clara/update-inbound-queue-benchmarks branch July 26, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgeddes vgeddes vgeddes approved these changes

@yrong yrong yrong approved these changes

@alistair-singh alistair-singh Awaiting requested review from alistair-singh

@doubledup doubledup Awaiting requested review from doubledup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claravanstaden @vgeddes @yrong