Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable serde feature in no_std #8

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

bluele
Copy link

@bluele bluele commented Jan 16, 2023

Hi there,

Since the serde feature depends on std, compiling in no_std fails.
I've made a PR to this branch because I was aware of your upstream PR, but please let me know if it is not appropriate.

Signed-off-by: Jun Kimura junkxdev@gmail.com

Signed-off-by: Jun Kimura <junkxdev@gmail.com>
Copy link
Collaborator

@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks for the contribution! ✨

@claravanstaden claravanstaden merged commit 3bf70f4 into Snowfork:feat/contribution Jan 16, 2023
claravanstaden pushed a commit that referenced this pull request Jan 17, 2023
Signed-off-by: Jun Kimura <junkxdev@gmail.com>

Signed-off-by: Jun Kimura <junkxdev@gmail.com>
claravanstaden pushed a commit that referenced this pull request Jan 19, 2023
Signed-off-by: Jun Kimura <junkxdev@gmail.com>

Signed-off-by: Jun Kimura <junkxdev@gmail.com>
ralexstokes pushed a commit that referenced this pull request Jan 22, 2023
Signed-off-by: Jun Kimura <junkxdev@gmail.com>

Signed-off-by: Jun Kimura <junkxdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants