test: fiches MT en DSFR (ne pas merger) #1483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| rs.pipe(unzipper.Parse()) | ||
| .on("entry", function (entry) { | ||
| const filePath = entry.path.replace( |
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip") High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 1 month ago
To fix the problem, we need to ensure that the entry.path does not contain any directory traversal sequences like .. before using it to construct outputPath. This can be achieved by validating the filePath and ensuring it is within the intended directory.
- We will add a check to ensure that
filePathdoes not contain..and is within theoutputDir. - If the
filePathis invalid, we will skip processing that entry and log a warning message. - This change will be made in the
downloadZipfunction, specifically around the construction and usage ofoutputPath.
Suggested changeset
1
targets/ingester/src/cli.ts
| @@ -97,4 +97,17 @@ | ||
|
|
||
| // Validate filePath to prevent directory traversal | ||
| if (filePath.includes("..")) { | ||
| console.log('skipping bad path', filePath); | ||
| entry.autodrain(); | ||
| return; | ||
| } | ||
|
|
||
| const outputPath = path.join(outputDir, filePath); | ||
|
|
||
| if (!outputPath.startsWith(outputDir)) { | ||
| console.log('skipping bad path', filePath); | ||
| entry.autodrain(); | ||
| return; | ||
| } | ||
|
|
||
| if (entry.type === "Directory") { |
Copilot is powered by AI and may make mistakes. Always verify output.
m-maillot
force-pushed
the
linked/fiches-mt-dsfr
branch
from
3cbb1a2
to
3f29399
Compare
m-maillot
had a problem deploying
to
review-auto
GitHub Actions
Failure
|
|
🎉 Deployment for commit f318231 : Docker images
|
m-maillot
had a problem deploying
to
review-auto
GitHub Actions
Failure
SocialGroovyBot
temporarily deployed
to
review-linked-feat-fiches-mt-dsfr-5647pj
m-maillot
had a problem deploying
to
review-auto
GitHub Actions
Failure
SocialGroovyBot
temporarily deployed
to
review-linked-feat-fiches-mt-dsfr-5647pj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.