Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use configuration to use a custom logo and css in the report #285

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

edelagnier
Copy link
Contributor

I added three parameters to the dashlord yml :

  • logo: url of the logo
  • logoAltTxt: alt text for the logo
  • customCss: url of the css (note the css file needs to be hosted to be recognised as mime type css, I added the necessary information to the dashlord-template readme

Note, I tried but it didn't seem easily possible to simply include the logo in the existing header (it did gave me the opportunity to play around with the dsfr-react repo) so I just replaced it in the end

Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@edelagnier
Copy link
Contributor Author

edelagnier commented Nov 3, 2023

Here is an exemple of custom css/logo : https://multi-coop.github.io/dashlord/about/
see the configuration file : https://github.com/multi-coop/dashlord/blob/main/dashlord.yml

But I realise I didn't rerun the job without logo at all. I will try and come back with changes if needed

@edelagnier
Copy link
Contributor Author

Pas de souci si les champs logo / altlogo ne sont pas renseignés : https://agatha-budget.github.io/dashlord/

@revolunet
Copy link
Member

petit problème sur le logo sur le dashboard de multi, il est XXXL :)

@revolunet revolunet changed the title Use configuration to use a custom logo and css in the report fix: use configuration to use a custom logo and css in the report Nov 3, 2023
@edelagnier
Copy link
Contributor Author

ah mince, ce n'est pas le cas sur mon ecran... je vais regarder ça :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants