Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): add missing h1s fix #163 #313

Merged
merged 1 commit into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions report/www/pages/category/[category].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,24 @@ import Head from "next/head";
import uniq from "lodash.uniq";

import { Dashboard } from "../../src/components/Dashboard";
import report from '@/report.json';
import dashlordConfig from '@/config.json';
import report from "@/report.json";
import dashlordConfig from "@/config.json";

const Tag = ({ report, tag }: { report: DashLordReport; tag: string }) => {
const Category = ({
report,
category,
}: {
report: DashLordReport;
category: string;
}) => {
return (
<>
<Head>
<title>Catégorie {tag} - {dashlordConfig.title}</title>
<title>
Catégorie {category} - {dashlordConfig.title}
</title>
</Head>
<h1>Tableau de bord : {category}</h1>
<Dashboard report={report} />
</>
);
Expand All @@ -34,4 +43,4 @@ export const getStaticPaths: GetStaticPaths = async () => ({
fallback: false,
});

export default Tag;
export default Category;
1 change: 1 addition & 0 deletions report/www/pages/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const Home: NextPage = () => {
<Head>
<title>{dashlordConfig.title}</title>
</Head>
<h1>Tableau de bord</h1>
<Dashboard report={report} />
</>
);
Expand Down
1 change: 1 addition & 0 deletions report/www/pages/startup/[...id].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const PageStartup = ({ report, id }: { report: UrlReport[]; id: string }) => {
{id} - {dashlordConfig.title}
</title>
</Head>
<h1>Tableau de bord : {id}</h1>
<Dashboard report={report} />
</>
);
Expand Down
1 change: 1 addition & 0 deletions report/www/pages/tag/[tag].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const Tag = ({ report, tag }: { report: DashLordReport; tag: string }) => {
Tag {tag} - {dashlordConfig.title}
</title>
</Head>
<h1>Tableau de bord : {tag}</h1>
<Dashboard report={report} />
</>
);
Expand Down
Loading