Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report): Tabs #88

Merged
merged 7 commits into from
Oct 15, 2021
Merged

feat(report): Tabs #88

merged 7 commits into from
Oct 15, 2021

Conversation

revolunet
Copy link
Member

@revolunet revolunet commented Oct 5, 2021

Add tabs in detail view :

  • bonnes pratiques : lighthouse, trackers, page stats
  • performance : updown.io
  • sécu : http, ssl, nucléi, zap, trivy, codescan, codeql...

And some cosmetics fixes

demo : https://dashlord.fabrique.social.gouv.fr/

Capture d’écran 2021-10-05 à 17 25 09

@revolunet revolunet changed the title feat: Tabs feat(report): Tabs Oct 5, 2021
url={url}
urlText="Retester l'url"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'aurai mis "Rapport détaillé" car cela ne relance pas le test et paraît moins évident même si effectivement on peut le relancer sur le site. Et plus généralement "rapport détaillé" sur tous les liens vers les rapports. A voir avec les UX. Qu'en penses-tu? @revolunet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@tristanrobert tristanrobert merged commit 3cb67c6 into main Oct 15, 2021
@tristanrobert tristanrobert deleted the tabs branch October 15, 2021 14:41
@github-actions
Copy link

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants