perf(nginx4spa): restrict envsub files type (#521)

SocialGouv · Mar 10, 2021 · 1e41998 · 1e41998
1 parent 7c6532d
commit 1e41998
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/nginx4spa/envsub.sh b/nginx4spa/envsub.sh
@@ -21,7 +21,7 @@ echo "PORT=${PORT:="80"}" >> /tmp/env-vars
 while IFS='=' read -r KEY VALUE
 do
   # In every files in the dir, replace the environment variables value
-  find ${WWW_DIRECTORY} -type f -exec \
+  find ${WWW_DIRECTORY} -type f -regex ".*\.\(conf\|txt\|html\|htm\|js\|css\)"  -exec \
     sed -i -e "s|${DELIMITER}${KEY}${DELIMITER}|${VALUE}|g" {} \;
   # replace in nginx.conf too
   sed -i -e "s|${DELIMITER}${KEY}${DELIMITER}|${VALUE}|g" /etc/nginx/nginx.conf

diff --git a/nginx4spa/test/envsub.bats b/nginx4spa/test/envsub.bats
@@ -31,3 +31,9 @@ teardown() {
   assert_output "// nginx4spa/test/foo/bar/bar.js with VERSION=x.y.z" ]
   assert_success
 }
+
+@test "should not replace the VERSION with x.y.z in foo/bar/bar.png" {
+  run wget -qO - localhost:8888/foo/bar/bar.png
+  assert_output "// nginx4spa/test/foo/bar/bar.png with VERSION=%%VERSION%%" ]
+  assert_success
+}
diff --git a/nginx4spa/test/fixtures/foo/bar/bar.png b/nginx4spa/test/fixtures/foo/bar/bar.png