Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(nginx4spa): restrict envsub files type #521

Merged
merged 4 commits into from
Mar 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nginx4spa/envsub.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ echo "PORT=${PORT:="80"}" >> /tmp/env-vars
while IFS='=' read -r KEY VALUE
do
# In every files in the dir, replace the environment variables value
find ${WWW_DIRECTORY} -type f -exec \
find ${WWW_DIRECTORY} -type f -regex ".*\.\(conf\|txt\|html\|htm\|js\|css\)" -exec \
sed -i -e "s|${DELIMITER}${KEY}${DELIMITER}|${VALUE}|g" {} \;
# replace in nginx.conf too
sed -i -e "s|${DELIMITER}${KEY}${DELIMITER}|${VALUE}|g" /etc/nginx/nginx.conf
Expand Down
6 changes: 6 additions & 0 deletions nginx4spa/test/envsub.bats
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,9 @@ teardown() {
assert_output "// nginx4spa/test/foo/bar/bar.js with VERSION=x.y.z" ]
assert_success
}

@test "should not replace the VERSION with x.y.z in foo/bar/bar.png" {
run wget -qO - localhost:8888/foo/bar/bar.png
assert_output "// nginx4spa/test/foo/bar/bar.png with VERSION=%%VERSION%%" ]
assert_success
}
1 change: 1 addition & 0 deletions nginx4spa/test/fixtures/foo/bar/bar.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.