Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nginx): Use unpriviledged docker images #956

Merged
merged 8 commits into from
Mar 28, 2022
Merged

chore(nginx): Use unpriviledged docker images #956

merged 8 commits into from
Mar 28, 2022

Conversation

achauve
Copy link
Member

@achauve achauve commented Mar 24, 2022

No description provided.

@achauve achauve requested a review from revolunet March 24, 2022 10:49
@achauve achauve force-pushed the chore-use-unpriviledged-nginx-docker-images branch from 28fc511 to edf57d2 Compare March 24, 2022 11:19
@revolunet
Copy link
Member

dans les dockerfile, $uid est une fois en minuscule et une fois en majuscule 🤔

@achauve
Copy link
Member Author

achauve commented Mar 24, 2022

dans les dockerfile, $uid est une fois en minuscule et une fois en majuscule 🤔

Exact c'est bien $UID l'ARG définit dans l'image de base. Pas compris pourquoi le docker build n'a pas râlé...

@revolunet
Copy link
Member

Quand je lance docker run --entrypoint sh ghcr.io/socialgouv/docker/nginx4spa:sha-146560d83cfd2432fddaeab3eda4543ac75cfa92 -c id ca me dit "root" :)

@achauve
Copy link
Member Author

achauve commented Mar 24, 2022 •
edited
Loading

@revolunet exact ça marchait pas et sans warning de docker... $UID était un ARG de l'image parente mais je viens de voir qu'ils ne sont pas sauvegardés dans l'image. Donc j'ai remis les valeurs en dur...

@achauve achauve force-pushed the chore-use-unpriviledged-nginx-docker-images branch from 8c15ab3 to 24c0fa3 Compare March 25, 2022 11:01
@achauve
Copy link
Member Author

achauve commented Mar 25, 2022

@revolunet si ok comme ça, je fais pareil pour nginx4spa

@revolunet
Copy link
Member

testing here SocialGouv/www#957

@revolunet
Copy link
Member

je dirai que c'est un breaking change car le port passe à 8080 donc il faut bien le reporter dans chaque projet

@revolunet
Copy link
Member

donc c'est Ok pour moi, il faut "juste" faire de meme sur nginx4spa et release une major

achauve added 2 commits March 28, 2022 17:52
@achauve
chore: Remove envsubst from nginx4spa
38488e7
@achauve
feat: USE 8080 port in nginx and nginx4spa images
b58738a 
BREAKING CHANGE: port needs to be changed in projects using these images
@achauve
Copy link
Member Author

achauve commented Mar 28, 2022

@revolunet yes done ! tu valides ? (faut que tu cliques ;-) )

@revolunet revolunet merged commit 764247c into master Mar 28, 2022
@revolunet revolunet deleted the chore-use-unpriviledged-nginx-docker-images branch March 28, 2022 16:44
@revolunet
Copy link
Member

Au top 👍🙏

SocialGroovyBot added a commit that referenced this pull request Mar 28, 2022
@SocialGroovyBot
chore(release): version 7.0.0
394706f 
# [7.0.0](v6.70.1...v7.0.0) (2022-03-28)

### Bug Fixes

* deps ([#957](#957)) ([31e4150](31e4150))

### Features

* **nginx:** Use unpriviledged docker images ([#956](#956)) ([764247c](764247c))

### BREAKING CHANGES

* **nginx:** port needs to be changed in projects using these images
@github-actions
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revolunet revolunet revolunet approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achauve @revolunet