fix(app): loose bottom navigation bar #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudambro
approved these changes
Apr 1, 2022
|
bon ça a l'air de marcher avec les changements que j'ai fait, y'a juste la duplication d'une action DANS une personne qui renvoie ensuite à la liste de toutes les actions et pas la personne en question, mais je pense qu'on s'en fiche un peu, c'est à la marge, vraiment ! |
|
SonarCloud Quality Gate failed.
|
|
🎉 Deployment for commit 16a2546 : IngressesDocker images
|
SocialGroovyBot
added a commit
that referenced
this pull request
Apr 1, 2022
## [1.81.3](v1.81.2...v1.81.3) (2022-04-01) ### Bug Fixes * **app:** loose bottom navigation bar ([#546](#546)) ([97c23cd](97c23cd))
|
🎉 This PR is included in version 1.81.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J'ai refait et j'ai privilégié le fait d'afficher la barre tout le temps tant que le user n'a pas cliqué expressément. Tu peux tout à fait dire que tu n'es pas d'accord, je suis même chaud pour me ranger. Mais finalement je suis convaincu par ton exemple de twitter, et par la proposition originale que tu avais faite : on reste là où on est.
J'ai l'impression que ça marche.
screenpour identifier les pages qui "restaient dans leur univers en partant ailleurs".N'hésite pas à dire non ! Ton avis sur ces propositions est cool et tu as vachement plus d'expérience en mobile que moi (en fait c'est même toi qui m'a appris tout en mobile haha)
PS: ça corrige comme par magie https://trello.com/c/VAHgGV5a/609-bug-app-louche