Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

feat(directory): Basic directory for psychologists #27

Merged
merged 13 commits into from
Jan 24, 2022
Merged

feat(directory): Basic directory for psychologists #27

merged 13 commits into from
Jan 24, 2022

Conversation

desoindx
Copy link
Contributor

@desoindx desoindx commented Jan 5, 2022

No description provided.

@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 5, 2022 14:32 Inactive
@github-actions github-actions bot requested a deployment to mon-psy-sante-feat-annuaire-rq694c January 5, 2022 16:04 In progress
@desoindx desoindx closed this Jan 5, 2022
@desoindx desoindx reopened this Jan 5, 2022
@github-actions github-actions bot requested a deployment to mon-psy-sante-feat-annuaire-rq694c January 5, 2022 16:11 In progress
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 5, 2022 16:48 Inactive
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 10, 2022 09:42 Inactive
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 10, 2022 09:49 Inactive
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 10, 2022 09:55 Inactive
@desoindx desoindx force-pushed the feat/annuaire branch 2 times, most recently from 68c35d5 to 5c16187 Compare January 10, 2022 10:04
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 10, 2022 10:07 Inactive
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 10, 2022 10:37 Inactive
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 10, 2022 10:56 Inactive
@desoindx desoindx force-pushed the feat/annuaire branch 2 times, most recently from b0e5723 to c4a6e41 Compare January 10, 2022 11:15
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 10, 2022 11:18 Inactive
desoindx and others added 2 commits January 11, 2022 17:10
@desoindx
Use proper field
210514c
@desoindx
feat(ci): add seeds command (#28)
36048fc 
* Test .env

* feat: add db deploy

* Use proper DB URL

* fix: use devInitContainerCommand

* Do a db migration in docker

* run db:migrate

* Fix build

Co-authored-by: Desoindx <xavier.desoindre@hotmail.fr>
@desoindx desoindx marked this pull request as ready for review January 11, 2022 16:40
@github-actions github-actions bot requested a deployment to mon-psy-sante-feat-annuaire-rq694c January 11, 2022 16:49 In progress
@desoindx desoindx closed this Jan 12, 2022
@desoindx desoindx reopened this Jan 12, 2022
@desoindx desoindx closed this Jan 12, 2022
@desoindx desoindx reopened this Jan 12, 2022
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 12, 2022 11:16 Inactive
carolineBda
carolineBda reviewed Jan 18, 2022
View reviewed changes
.socialgouv/config.json Show resolved Hide resolved
public/robots.txt Show resolved Hide resolved
.env.production Show resolved Hide resolved
src/pages/healthz.tsx Outdated Show resolved Hide resolved
src/components/Directory.tsx Show resolved Hide resolved
src/db/models/psychologist.ts

Psychologist.init(
{
address: DataTypes.STRING,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On met pas un tableau ici ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pourquoi tu voudrais un tableau ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parce qu'on peut avoir plusieurs adresse non ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dans ce cas la je ferai une table address a part => pour l'instant c'est pas valider et il y a qu'une address dans DS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est validé que les psy peuvent avoir plusieurs adresses. On ajoutera les 2ème adresse avec l'admin de l'annuaire. Si on fait une table à part tu penses qu'il faut le prévoir des maintenant ? ça va impacter la recherche, ils auront potentiellement plus coordonnées géo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non, je ne pense pas qu'il soit utile de le prevoir maintenant. On a pas de facon de rajouter/modifier les addresses aujourd'hui => on aura un code intestable simplement

src/services/getAddressCoordinates.ts
`https://api-adresse.data.gouv.fr/search/?q=${firstAddress}&limit=1`
);
const response = await axios.get<CoordinatesAPI>(url).catch((error) => {
console.log("error", error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut pas resolve la promise ici ?

  • Updater le log d'erreurs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai pas compris ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que se passe-t-il si le call à l'API fail ? Il faut pas rajouter un Promise.reject(); ou un truc comme ça ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

justement si le call API fail on veut quand meme enregistrer le psy, donc non

src/services/psychologists.ts Show resolved Hide resolved
src/services/psychologists.ts Show resolved Hide resolved
src/components/Directory.tsx Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 18, 2022 14:07 Inactive
@github-actions github-actions bot temporarily deployed to mon-psy-sante-feat-annuaire-rq694c January 18, 2022 15:52 Inactive
revolunet
revolunet reviewed Jan 19, 2022
View reviewed changes
src/pages/annuaire.tsx Outdated Show resolved Hide resolved
@revolunet
Copy link
Member

Merci @desoindx @carolineBda 💪

Pour les CronJobs, je me permettrai de proposer une petite PR un peu plus tard pour les transformer en cronjob kubernetes, ce qui permettra d'avoir alerting+logs.

@github-actions
Copy link

🎉 Deployment for commit 128457e :

Ingresses
Docker images
  • 📦 docker pull ghcr.io/socialgouv/docker/wait-for-postgres:6.56.1
  • 📦 docker pull ghcr.io/socialgouv/mon-psy-sante/app:sha-128457ebb4d1b36c647877df630896659b8ca44e
Debug

@desoindx desoindx merged commit 3ffcbd8 into main Jan 24, 2022
@desoindx desoindx deleted the feat/annuaire branch January 24, 2022 08:27
SocialGroovyBot added a commit that referenced this pull request Jan 24, 2022
@SocialGroovyBot
chore(release): version 1.7.0
f89a93b 
# [1.7.0](v1.6.0...v1.7.0) (2022-01-24)

### Features

* **directory:** Basic directory for psychologists ([#27](#27)) ([3ffcbd8](3ffcbd8)), closes [#28](#28)
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@revolunet revolunet revolunet left review comments

@carolineBda carolineBda carolineBda approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@desoindx @revolunet @SocialGroovyBot @carolineBda