Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deactivate): make it silent #18

Merged
merged 2 commits into from
Jun 26, 2023
Merged

fix(deactivate): make it silent #18

merged 2 commits into from
Jun 26, 2023

Conversation

revolunet
Copy link
Member

Having notifications about failed deactivate may be annoying.

as this step is out of control from the end users, i think it should not report failures to them (and may be reported to us in sentry)

ex: https://github.com/SocialGouv/mda/actions/runs/5271833354/jobs/9533269464

Julien Bouquillon added 2 commits June 15, 2023 00:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@revolunet revolunet requested review from devthejo and matmut7 June 14, 2023 22:10
@revolunet revolunet merged commit 31b3e55 into master Jun 26, 2023
SocialGroovyBot added a commit that referenced this pull request Jul 24, 2023
# [1.9.0](v1.8.3...v1.9.0) (2023-07-24)

### Bug Fixes

* add input ([556797f](556797f))
* **deactivate:** make it silent ([#18](#18)) ([31b3e55](31b3e55))

### Features

* override kubeconfig ([c167d7d](c167d7d))
* override kubeconfig [#19](#19) ([c0ef756](c0ef756))
* **trivy:** upload sarif data ([#23](#23)) ([7d03818](7d03818))
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants