hotfixes #69
Merged
hotfixes #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ameeshaagrawal
commented
Feb 28, 2025
ameeshaagrawal
commented
- Added default auction manager in delivery helper. If an app doesn't set auction manager, we will use our auction manager
- Added a check to ignore if promise is address(0) while checking if previous batch was executed in callback
rookmate
previously approved these changes
Feb 28, 2025
arthcp
previously approved these changes
Mar 3, 2025
arthcp
requested changes
Mar 3, 2025
Contributor
|
can you also update the storage test of address resolver to check the new last storage that is defaultAuctionManager? |
rookmate
previously approved these changes
Mar 3, 2025
arthcp
previously approved these changes
Mar 3, 2025
rookmate
approved these changes
Mar 3, 2025
arthcp
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.