-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar margin & spacing fixes #6238
Draft
yw4z
wants to merge
17
commits into
SoftFever:main
Choose a base branch
from
yw4z:sidebar-margin-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+48
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unequal spacings and margins on sidebar
Will keep this commit as draft for a while because i did this 2 month back and need to recheck code changes
Tried to control all spacings from a single file but that required more code changes because sidebar is split to 3 files (ParamsPanel.cpp, Plater.cpp, Tab.cpp)
This method only edits numbers for spacings and adds descriptions to them
TODO
• Aligning start point of combo boxes requires a bit fine tuning
IMPORTANT CHANGES TO CHECK
This changes should be check on high res monitors
• Parameters body text alignment src/slic3r/GUI/OG_CustomCtrl.cpp
Line 331
wxCoord h_pos = get_title_width() * m_em_unit + 4;
This line controls alignment of body text on parameters. basically added 4 to fix misalignment. static line element on titlebar using +5 and it looks on on my 2K monitor.
NOTES
• Titlebar has less margin on sides to create separation with its content
• Spacings changing on multiple filaments while it creating second row for that section. Its an existing bug
• I didnt change margins for parameter titlebars because it creates too much wasted space
COMPARISON
Before After
ALIGNMENT PREVIEW
• I didnt change margins for parameter titlebars because it creates too much wasted space
Preview on %200 scale