glcanvas: scale icons using icon size, not scale factor #8301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate toolbar icon size the same way as it done on windows: manipulate icon size, not toolbar scale. Scaling icons this way makes images sharper since they getting rasterized to a target size rather than being rasterized for 40px and scaled to a desired size later.
|
Need someone to test it on MacOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculate toolbar icon size the same way as it done on windows:
manipulate icon size, not toolbar scale.
Scaling icons this way makes images sharper since they getting rasterized to a target size rather than being rasterized for 40px and scaled to a desired size later.
Screenshots/Recordings/Graphs
Test samples with different toolbar scaling/app window width (top one is original, bottom one - updated)
Tests
Tested on Linux only.