Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework file provider for testing #337

Merged
merged 12 commits into from
Sep 10, 2020
Merged

Rework file provider for testing #337

merged 12 commits into from
Sep 10, 2020

Conversation

SavikPavel
Copy link
Contributor

@SavikPavel SavikPavel commented Aug 25, 2020 •
edited by wcoder
Loading

Description

FileProvider rework and tests added

API Changes

Whole IFileProvider interface reworked

Platforms Affected

  • Core (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code styles
  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@wcoder wcoder added the c/common Related to Common component. label Aug 25, 2020
@wcoder wcoder added this to the vNext milestone Aug 25, 2020
AlexandraMash
AlexandraMash previously approved these changes Aug 26, 2020
View reviewed changes
@wcoder
Copy link
Member

wcoder commented Aug 26, 2020

@SavikPavel Could you please fix the build error?

ImagePicker/ImagePicker.cs(77,44): error CS1061: 'IFileProvider' does not contain a definition for 'WriteStreamAsync' and no accessible extension method 'WriteStreamAsync' accepting a first argument of type 'IFileProvider' could be found (are you missing a using directive or an assembly reference?)

@wcoder
Copy link
Member

wcoder commented Aug 26, 2020

Is this issue affect us?

@wcoder wcoder changed the title Feature/file provider tests Rework file provider for testing Aug 26, 2020
savikpavel added 2 commits August 31, 2020 13:59
Merge branch 'master' into feature/file_provider_tests
da53a70 
# Conflicts:
#	Softeq.XToolkit.Common/Softeq.XToolkit.Common.csproj
GetAbsolutePath method added to IFileProvider
9aae3fd
@github-actions github-actions bot added the c/wl Related to WhiteLabel component. label Aug 31, 2020
@wcoder
Copy link
Member

wcoder commented Sep 1, 2020 •
edited
Loading 

"/Users/runner/work/1/s/samples/Playground/Playground.iOS/Playground.iOS.csproj" (default target) (4:6) ->
(_CompileToNative target) -> 
  MTOUCH : error MT2101: Can't resolve the reference 'System.Void System.IO.FileSystemAclExtensions::Create(System.IO.DirectoryInfo,System.Security.AccessControl.DirectorySecurity)', referenced from the method 'System.Void System.IO.Abstractions.DirectoryInfoWrapper::Create(System.Security.AccessControl.DirectorySecurity)' in 'System.IO.FileSystem.AccessControl, Version=4.0.5.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. [/Users/runner/work/1/s/samples/Playground/Playground.iOS/Playground.iOS.csproj]

@wcoder wcoder removed this from the vNext milestone Sep 4, 2020
@wcoder wcoder mentioned this pull request Sep 9, 2020
Merged
4 tasks
@wcoder wcoder added this to the vNext milestone Sep 9, 2020
@SavikPavel SavikPavel merged commit b47b726 into master Sep 10, 2020
@SavikPavel SavikPavel deleted the feature/file_provider_tests branch September 10, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcoder wcoder wcoder approved these changes

@sleushunou sleushunou Awaiting requested review from sleushunou

@TimofeyBurak TimofeyBurak Awaiting requested review from TimofeyBurak

@vadimpylsky vadimpylsky Awaiting requested review from vadimpylsky

@AlexandraMash AlexandraMash Awaiting requested review from AlexandraMash

Assignees
No one assigned
Labels
c/common Related to Common component. c/wl Related to WhiteLabel component.
Projects
None yet
Milestone
v2 beta 8
Development

Successfully merging this pull request may close these issues.
3 participants
@SavikPavel @wcoder @AlexandraMash