Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework MainThread methods #372

Merged
merged 19 commits into from
Sep 17, 2020
Merged

Rework MainThread methods #372

merged 19 commits into from
Sep 17, 2020

Conversation

wcoder
Copy link
Member

@wcoder wcoder commented Sep 15, 2020 •
edited
Loading

Description

Refactor Execute and related.

Issues Resolved

Closes #259

API Changes

Added:

  • MainThreadExecutorBase
  • Execute.Initialize
  • Execute.CurrentExecutor

Changed:

  • XToolkit.WhiteLabel.Threading.Execute -> XToolkit.Common.Threading.Execute
  • XToolkit.Common.Tasks.TaskDeferral -> XToolkit.Common.Threading.TaskDeferral
  • IPlatformProvider -> IMainThreadExecutor
  • DroidPlatformProvider -> DroidMainThreadExecutor
  • IosPlatformProvider -> IosMainThreadExecutor
  • FormsPlatformProvider -> FormsMainThreadExecutor

Removed:

  • All IPlatformProvider.InDesignMode flags

Platforms Affected

  • Core (all platforms)
  • iOS
  • Android

PR Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code styles
  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@github-actions github-actions bot added c/bindings Related to Bindings component. c/common Related to Common component. c/wl Related to WhiteLabel component. c/wl.essentials Related to WhiteLabel.Essentials component. c/wl.forms Related to Xamarin.Forms integration. p/Android Related to Android platform. p/iOS Related to iOS platform. labels Sep 15, 2020
@wcoder wcoder marked this pull request as ready for review September 16, 2020 12:18
@wcoder wcoder added this to the vNext milestone Sep 16, 2020
@wcoder wcoder merged commit 78990f6 into master Sep 17, 2020
@wcoder wcoder deleted the feature/mainthread-methods branch September 17, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SavikPavel SavikPavel SavikPavel approved these changes

@TimofeyBurak TimofeyBurak Awaiting requested review from TimofeyBurak

@nkrisko nkrisko Awaiting requested review from nkrisko

@vadimpylsky vadimpylsky Awaiting requested review from vadimpylsky

Assignees
No one assigned
Labels
c/bindings Related to Bindings component. c/common Related to Common component. c/wl.essentials Related to WhiteLabel.Essentials component. c/wl.forms Related to Xamarin.Forms integration. c/wl Related to WhiteLabel component. p/Android Related to Android platform. p/iOS Related to iOS platform.
Projects
None yet
Milestone
v2 beta 8
Development

Successfully merging this pull request may close these issues.

Execute.OnUIThread() might cause deadlock
2 participants
@wcoder @SavikPavel