Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android foreground notifications intent #421

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

AlexandraMash
Copy link
Contributor

@AlexandraMash AlexandraMash commented Nov 17, 2020

Description

Add ability to provide flags to Push Notification intent on Android (including No flags). By default no flags will be supplied now (previously the following flags were used: ActivityFlags.NewTask | ActivityFlags.ClearTask)

API Changes

Added:

  • ActivityFlags? Flags { get; set; } to NotificationIntentActivityInfo

Changed:

  • NotificationIntentActivityInfo(Type activityType, bool doCreateParentStack)
    => NotificationIntentActivityInfo(Type activityType, bool doCreateParentStack, ActivityFlags? flags = null)

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code styles
  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@github-actions github-actions bot added c/push-notifications Related to Push Notifications component. p/Android Related to Android platform. labels Nov 17, 2020
@SavikPavel SavikPavel added this to the vNext milestone Nov 17, 2020
@AlexandraMash AlexandraMash merged commit dfc568a into master Nov 17, 2020
@AlexandraMash AlexandraMash deleted the android-foreground-notifications-intent branch November 17, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/push-notifications Related to Push Notifications component. p/Android Related to Android platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants