Skip to content

Commit

Permalink
Update Titles + Formatting
Browse files Browse the repository at this point in the history
Change the title of the tests that test invalid string over to data, since they are testing the data itself rather than the type of data.
Fix section formatting.
  • Loading branch information
elliot-huffman committed Jun 14, 2024
1 parent 7043fd8 commit 1d7cd4b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions test/toObjectId.test.mts
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,17 @@ describe('Convert To Object ID', () => {
done();
});
});

describe('Expected Failures', () => {
it('Reject Invalid Type - Junk String', (done) => {
it('Reject Invalid Data - Junk String', (done) => {
// Test Junk String input
expect(convertToObjectId.bind(convertToObjectId, 'Hello world!')).to.throw('The provided SID is not an Entra ID SID!');

// Finish testing section
done();
});

it('Reject Invalid Type - Invalid SID', (done) => {
it('Reject Invalid Data - Invalid SID', (done) => {
// Test Junk String input
expect(convertToObjectId.bind(convertToObjectId, 'S-1-5-711957920-1182741761-3248840125-1169651596')).to.throw('The provided SID is not an Entra ID SID!');

Expand Down
5 changes: 3 additions & 2 deletions test/toSid.test.mts
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,17 @@ describe('Convert To SID', () => {
done();
});
});

describe('Expected Failures', () => {
it('Reject Invalid Type - Junk String', (done) => {
it('Reject Invalid Data - Junk String', (done) => {
// Test Junk String input
expect(convertToSid.bind(convertToSid, 'Hello world!')).to.throw('The specified object ID is not a valid UUID v4!');

// Finish testing section
done();
});

it('Reject Invalid Type - Invalid UUID', (done) => {
it('Reject Invalid Data - Invalid UUID', (done) => {
// Test Junk String input
expect(convertToSid.bind(convertToSid, 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx')).to.throw('The specified object ID is not a valid UUID v4!');

Expand Down

1 comment on commit 1d7cd4b

@elliot-huffman
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #86

Please sign in to comment.