-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOL-79060] Health indicator should capture binding health statuses #145
Comments
Ping @Mrc0113 |
The To add this, we'll need to do some digging around to see if there's a good way to add binding statuses to the binder's health indicator (since its not a composite health indicator) or if/how other SCSt binders capture binding health statuses. If there's no good way to add this to the existing indicator, we might have to add some custom config option to change the |
This has been logged in the Solace Jira and we are targeting Q1CY2023 for a fix. |
@GreenRover Just double checking, but did you post the correct stacktrace? Looking again at the one you posted, this looks like an error on the producer side. But you shouldn't get this error by just deleting the queue. Deleting the queue should result in a different error, and it would be one on the consumer. I was only able to reproduce a similar stacktrace by killing the session (e.g. session reconnect attempts exhausted). But the health for that is already captured by the existing health indicator (i.e. the PubSub+ session health). |
I retestet now with: A "deleted queue" gives following log message: Not connected but reconnecting: Not connected end of reconnectes: org.springframework.messaging.MessagingException: Unable to send message to topic tms/monitoring/monalesy/p/v1/serviceState/request; nested exception is com.solacesystems.jcsmp.JCSMPTransportException: (JCSMPTransportException) Error receiving data from underlying connection. |
Is the queue that you're deleting the one the input binding is consuming messages from? Or do you have a queue subscribed to the output binding destination, |
the queue i delete is the from the input binding |
With release 2.5.0 when a queue was deleted manually the service logs:
But |
# Global Changes * Solace PubSub+ Messaging API for Java (JCSMP) upgraded to `10.21.0` * Spring Boot upgraded to `3.1.5` * Spring Cloud upgraded to `2022.0.4` # Specific Project Changes ## Solace Spring Cloud Stream Binder * Added health indicators to capture flow health * closes #145 * Added support for Solace PubSub+ partitioned queues * Fixed potential error channel name collisions
@GreenRover , apologies for taking so long to address this issue. Did you also log an RT for this? If so, do you know the ticket reference #? |
Hello Andreaw, no there is no related RT. |
Scenario:
Result:
Expected:
The SolaceBinderHealthIndicator of the application change to unhealthy.
Because mas last 10 pull requests was not merged i only create an issue
The text was updated successfully, but these errors were encountered: