Power consumption + integral + misc qol changes #79
Conversation
no formula for median implemented
Added Median Value, Function to multiply data sets, custom KPH dataset and motor power consumption dataset
FUNNY BUTTON
ITS FIXED NOW!!!! UwU <3 xD
and also autoupdate :)
get f'd
FUCK KPH WE ONLY USE FREEDOM NUMBERS RAHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
no mo' its fix
L L L L L L L L L L L L L L L L L L L L L L L L L L L L L L L L INTEFRAL INTEGRAL INTEGRAL if only my calc 1 teacher copuld see my now oh boy
IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING IM SPINNING Now, now, let's 🔠7️⃣ hear 👂 this post 🚩 out, fellas 👨. It's important ‼ to hear 👂 both sides 👈👉, and the Right ✔ has a long 🤪 and intellectual 😠 theoretical tradition ✝. Uncle 🧔 Ted 🤮, that Evola guy 👦, the big 🔝 Adolf ⚫ H 🅱. himself 🔪🙈, the Christchurch gentleman 👴, Jordan 🇯🇴 Peterson, I 👁 could go 🏃 on. The list 📜📝 is endless ♾🏖, and I 👁 don't think 🤔 the SJW 😡🔪 Left ⬅👈 should dismiss 😡 high 🔫 level 📏 ideas 💡 offhand simply 🍦 because they involve bombing 💣 orphanages 🏫. It may 🌼🌷🌹 even 💅 be profitable. Let's 👏 have a debate 💬 in the free 🆓 marketplace of ideas 💡. If you 👆 could expand 💗 your 👉 orphan 👶 killing 🔪🔫 theory 🤑😵💫 to something 😩 lengthier -- say 🗣 manifesto 📕 length 📏 -- and force 🍆 a major ↔ newspaper 🗞 to publish 🤓 it, I 👁 think 🤔 you 👆 could really 💯 be onto 😿 something 🙅♀️ here.
|
@Seth10001 sorry for the different PR (I hate forks). Here's the diff for the changes you haven't reviewed: https://github.com/Solar-Gators/Pit-GUI/pull/79/files/6157d1ff117530788f2acac53de9665e0989382c..4eaff788de5f97bb9ca8937b2d2e7bd2bb86c87b I made the change you suggested to better show what the setting does (I added an information popup). In addition, since the last approval, I reworked your password code to be cleaner, and Bradley implemented a Reimann sum integral statistic! (so that plus the new power_consumption statistic he added is pretty sick). Also, please let me know if you figure out how to fix the e2e test. Do we need to adjust the cypress test file, or something else? |
|
The e2e tests apear to be broken because the db seed no longer works |
client/src/shared/sdk/telemetry.ts
Outdated
| @@ -78,6 +78,7 @@ export interface DataResponse extends CanData { | |||
| rx0: PowerBoard_RX0; | |||
| rx1: PowerBoard_RX1; | |||
| }; | |||
| calculated: {}; | |||
There was a problem hiding this comment.
Why is this needed? Do you plan to return real time calcaulted data later?
There was a problem hiding this comment.
I did this in a different way (that works on client), but now am reminded why I did it this way. The backend build is failing now, if you check the workflow run. Let me know if there's a better way to avoid this error, other than putting calculated in DataResponse.
Error: Object literal may only specify known properties, and 'calculated' does not exist in type 'DataResponse'.
There was a problem hiding this comment.
When you remove it from the schema here, you also need to change the API response which is using this schema to remove the calculated key here:
I made the response of type DataResponse to ensure that the response shape always matches the DataResponse schema. Static analysis is great :)
Bradley the 🐐