Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat thread with proof #550

Merged
merged 71 commits into from
Apr 3, 2024
Merged

Chat thread with proof #550

merged 71 commits into from
Apr 3, 2024

Conversation

bourgeoa
Copy link
Contributor

@bourgeoa bourgeoa commented May 29, 2023

result of merging chat main (including message signature) and chat-threads.

This is nicely working with 2 remaining isssues related to send :

  • no area to add a comment (send area) on a thread opened in the past (resolved)
  • on same day you cannot add new comments. Send fails and you must reload the chat

@timea-solid
Copy link
Member

If this is also containing the chat-thread branch, I guess we can close that one?

Copy link
Member

@timea-solid timea-solid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

package.json Outdated
@@ -55,6 +55,7 @@
},
"homepage": "https://github.com/solidos/solid-ui",
"dependencies": {
"16": "^0.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is by mistake here?

@bourgeoa bourgeoa requested review from timea-solid and timbl and removed request for timea-solid February 18, 2024 17:48
@bourgeoa bourgeoa self-assigned this Feb 18, 2024
@bourgeoa bourgeoa mentioned this pull request Feb 18, 2024
29 tasks
@bourgeoa bourgeoa merged commit 42e66c3 into main Apr 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants