Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
.devcontainer.json
file is harmless to people who don't use it.I added a note about its availability in the readme.
And I made the following changes
scripts/dev
to wrap around the initial install & reset commands (again, the presence of this file should be harmless to people who don't use it)export NVM_DIR="$HOME/.nvm"
toexport NVM_DIR="${NVM_DIR:-$HOME/.nvm}"
everywhere, to make this oneliner robust against environments (such as this one) that use a different NVM_DIR than~/.nvm
.nvm install
command toscripts/add
, so that for instance node-solid-server can get its own preferred node version. As far as I know this command is a noop if the requested version from.nvmrc
is already available on the host system (but if not then we need to think this through some more).