TS-4265: Thread initialization update.

.clang-tidy

@@ -1 +1 @@
-Checks: -*,readability-braces-around-statements,modernize-use-nullptr
+Checks: -*,modernize-loop-convert,modernize-use-bool-literals,modernize-deprecated-headers,performance-unnecessary-value-param,performance-faster-string-find,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-use-nullptr,modernize-use-override

.gitignore

@@ -143,6 +143,7 @@ rc/trafficserver.service
 .libs/
 
 .svn/
+.vscode/
 
 tsxs
 

ci/coverity-model.cpp

@@ -50,3 +50,13 @@ void _TSReleaseAssert(const char* txt, const char* f, int l)
 }
 
 } /* extern "C" */
+
+// Teach Coverity that the my_exit() in logstats.cc exits ...
+struct ExitStatus {
+};
+
+void
+my_exit(const ExitStatus &status)
+{
+  __coverity_panic__();
+}

ci/tsqa/nosetests → ci/jenkins/bin/autest.sh

@@ -1,5 +1,5 @@
-#! /usr/bin/env bash
-
+#!/bin/sh
+#
 #  Licensed to the Apache Software Foundation (ASF) under one
 #  or more contributor license agreements.  See the NOTICE file
 #  distributed with this work for additional information
@@ -16,15 +16,31 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
-set -e # exit on error
+cd "${WORKSPACE}/src"
+[ -d tests ] || exit 0
+
+autoreconf -if
+
+INSTALL="${WORKSPACE}/${BUILD_NUMBER}/install"
+SANDBOX="/tmp/ausb-$$"
+
+mkdir -p $INSTALL
 
-TSQA=$(cd $(dirname $0); pwd)
+./configure --prefix="$INSTALL" \
+            --with-user=jenkins \
+            --enable-experimental-plugins \
+            --enable-example-plugins \
+            --enable-ccache \
+            --enable-debug \
+            --enable-werror
 
-cd $TSQA
+# Build and run regressions
+${ATS_MAKE} ${ATS_MAKE_FLAGS} V=1 Q=
+${ATS_MAKE} check VERBOSE=Y && ${ATS_MAKE} install
 
-. ./virtualenv/bin/activate
+/usr/bin/autest -D ./tests/gold_tests --sandbox "$SANDBOX" --ats-bin "${INSTALL}/bin"
+status="$?"
+[ -d "$SANDBOX" ] && rm -rf "$SANDBOX"
 
-./virtualenv/bin/nosetests \
-        --with-xunit \
-        --nocapture \
-	"$@"
+[ "0" != "$status" ] && exit -1
+exit 0

ci/jenkins/bin/tsqa.sh → ci/jenkins/bin/clang-format.sh

@@ -16,11 +16,23 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
-# Run all the TSQA tests.
-TSQA_LAYOUT_DIR="${WORKSPACE}/${BUILD_NUMBER}"
-cd "${WORKSPACE}/src/ci/tsqa" || exit 2
-make test "TSQA_LAYOUT_DIR=${TSQA_LAYOUT_DIR}"
-status=$?
+cd "${WORKSPACE}/src"
+autoreconf -if && ./configure
 
-# Exit with proper status
-exit $status
+# Test clang-format, copy our version of clang-format if needed
+if [ ! -d .git/fmt ]; then
+    if [ -z "${ghprbTargetBranch}" ]; then
+	cp -rp /home/jenkins/clang-format/master .git/fmt
+    else
+	# This is for Github PR's, to make sure we use the right clang-format for the branch.
+	# This is not an issue on normal branch builds, since they will have the right .git/fmt.
+	cp -rp /home/jenkins/clang-format/${ghprbTargetBranch} .git/fmt
+    fi
+fi
+
+${ATS_MAKE} -j clang-format
+git diff --exit-code
+[ "0" != "$?" ] && exit -1
+
+# Normal exit
+exit 0

ci/jenkins/bin/github.sh

@@ -16,30 +16,25 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
-# Setup autoconf
+INSTALL="${WORKSPACE}/${BUILD_NUMBER}/install"
+
+mkdir -p ${INSTALL}
 cd src
 autoreconf -if
 
-mkdir -p "${WORKSPACE}/${BUILD_NUMBER}/install"
-
-./configure --prefix="${WORKSPACE}/${BUILD_NUMBER}/install" \
+./configure --prefix="${INSTALL}" \
             --with-user=jenkins \
             --enable-experimental-plugins \
             --enable-example-plugins \
             --enable-ccache \
             --enable-debug \
             --enable-werror
 
-# Test clang-format (but only where we have the local copy of clang-format, i.e. linux)
-if [ -d /usr/local/fmt ]; then
-    [ ! -d .git/fmt ] && cp -rp /usr/local/fmt .git
-    make clang-format
-    git diff --exit-code
-    [ "0" != "$?" ] && exit -1
-fi
-
 # Build and run regressions
-make -j4
-make check VERBOSE=Y && make install
+${ATS_MAKE} ${ATS_MAKE_FLAGS} V=1 Q=
+${ATS_MAKE} check VERBOSE=Y && ${ATS_MAKE} install
+
+${INSTALL}/bin/traffic_server -K -k -R 1
+[ "0" != "$?" ] && exit -1
 
-"${WORKSPACE}/${BUILD_NUMBER}/install/bin/traffic_server" -K -k -R 1
+exit 0