Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ukvm/console: return actual number of bytes written #196

Closed
wants to merge 1 commit into from

Conversation

hannesm
Copy link
Contributor

@hannesm hannesm commented Jun 4, 2017

instead of the string length

@hannesm
Copy link
Contributor Author

hannesm commented Jun 4, 2017

this addresses mirage/mirage-flow#4 (comment) and comes along with mirage/mirage-solo5#19 and mirage/mirage-console-solo5#12 (but this change in here is very independent, and does not change any API)

@mato
Copy link
Member

mato commented Jun 7, 2017

There are multiple issues with the solo5.h APIs, I'm working on a minimal refresh that corrects the most egregious problems without actually redesigning anything.

In the specific case of the console, I'm going to change solo5_console_write() to just return void; I don't see any point in trying to "recover" from failed console writes.

PR coming up once it's ready, we can discuss the changes there.

@hannesm
Copy link
Contributor Author

hannesm commented Jun 15, 2017

my motivation was to unify the semantics of console writes across backends, please see mirage/mirage-flow#4 (comment) for more information. but i agree that error recovery from partial writes is slightly overengineering -- but I'd still like to have a unified semantics here (as in: writing to the console may fail or be partial), and properly documented error cases.

@hannesm
Copy link
Contributor Author

hannesm commented Jun 21, 2017

superseeded by #201

@hannesm hannesm closed this Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants