Add audit logs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add logs
omerlh
suggested changes
Jul 8, 2018
src/Controllers/EncryptController.cs
Outdated
| await mKeyVaultClient.GetKeyAsync(keyId); | ||
| } | ||
| catch (KeyVaultErrorException e) when (e.Response.StatusCode == HttpStatusCode.NotFound) | ||
| { | ||
| await mKeyVaultClient.CreateKeyAsync($"https://{mKeyVaultName}.vault.azure.net", hash, mKeyType, 2048); |
There was a problem hiding this comment.
maybe worth adding log here?
| } | ||
| catch (KeyVaultErrorException e) | ||
| { | ||
| mLogger.Warning(e, "Decryption request failed, SourceIP: {sourceIp}, ServiceAccount: {sa}", |
|
@omerlh added. |
added 2 commits
July 8, 2018 13:50
omerlh
suggested changes
Jul 8, 2018
| } | ||
| catch (KeyVaultErrorException e) | ||
| { | ||
| mLogger.Warning(e, "Decryption request failed, SourceIP: {sourceIp}, ServiceAccount: {sa}", |
omerlh
approved these changes
Jul 8, 2018
omerlh
added a commit
that referenced
this pull request
Jul 9, 2018
…ogs"" This reverts commit 8a70ea4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1