BadRequest validation added to Kamus API #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AleF83 bumb version please |
omerlh
suggested changes
Jan 21, 2019
| @@ -28,23 +29,28 @@ public EncryptController(IKeyManagement keyManagement) | |||
| [Route("api/v1/encrypt")] | |||
| public async Task<ActionResult> Encrypt([FromBody]EncryptRequest body) | |||
| { | |||
| if (!ModelState.IsValid) | |||
| { | |||
| return BadRequest("One of required fields doesn't present in request body."); | |||
There was a problem hiding this comment.
Log the validation error please
| @@ -35,6 +35,11 @@ public DecryptController(IKubernetes kubernetes, IKeyManagement keyManagement) | |||
| [Authorize(AuthenticationSchemes = "kubernetes")] | |||
| public async Task<ActionResult> Decrypt([FromBody] DecryptRequest body) | |||
| { | |||
| if (!ModelState.IsValid) | |||
| { | |||
| return BadRequest("One of required fields doesn't present in request body."); | |||
There was a problem hiding this comment.
Log validation error please
|
See last commit. Do you mean that? |
|
I want to add some tests to blackbox. Something that isn't happy flow. |
|
sounds good, should be easy to do, need help? |
omerlh
reviewed
Jan 22, 2019
Co-Authored-By: AleF83 <AlexanderFux83@gmail.com>
Co-Authored-By: AleF83 <AlexanderFux83@gmail.com>
|
I've added test case for BadRequest. Review once again please |
omerlh
suggested changes
Jan 22, 2019
| public string SerivceAccountName | ||
| { | ||
| get; | ||
| set; | ||
| } | ||
|
|
||
| [JsonProperty(PropertyName = "namespace", Required = Required.Always)] |
Co-Authored-By: AleF83 <AlexanderFux83@gmail.com>
Co-Authored-By: AleF83 <AlexanderFux83@gmail.com>
Co-Authored-By: AleF83 <AlexanderFux83@gmail.com>
Co-Authored-By: AleF83 <AlexanderFux83@gmail.com>
omerlh
suggested changes
Jan 22, 2019
| @@ -125,5 +125,22 @@ public async Task AnonymousRequestToDecryptEndpointShouldFail() | |||
|
|
|||
| Assert.Equal(HttpStatusCode.Unauthorized, result.StatusCode); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task Encrypt_BadRequest_ShouldFail() | |||
There was a problem hiding this comment.
What about decryptor tests?
Co-Authored-By: AleF83 <AlexanderFux83@gmail.com>
omerlh
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #93