Change the api to "extend" syntax #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataly87s
force-pushed
the
extend-syntax
branch
from
e912f22 to
409b6db
Compare
nataly87s
force-pushed
the
extend-syntax
branch
from
409b6db to
986abc6
Compare
AvivRubys
suggested changes
Sep 16, 2018
There was a problem hiding this comment.
I'm in Romania so I didn't go through it thoroughly, but a few things:
- This is a huge breaking change, so it needs a major version bump IMO, even if we are on 0.x
- Is the breaking change worth it? Maybe we can create a version that supports both APIs and start with incremental changes? Otherwise big projects will never be migrated. (Unless - wanna write a codemod?)
AvivRubys
suggested changes
Sep 26, 2018
lib/legacySupport.js
Outdated
| var extender = extenders[name]; | ||
|
|
||
| AnalyticsDispatcher.prototype[name] = function () { | ||
| console.warn('AnalyticsDispatcher.' + name + ' is deprecated, use AnalyticsDispatcher.extend('+name+'(arguments)) instead'); |
There was a problem hiding this comment.
Add a boolean or something to only warn once (maybe once per extender)? Otherwise it will spam the console.
And disable logging in production
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "shisell", | |||
| "version": "0.4.1", | |||
| "version": "0.5.0", | |||
There was a problem hiding this comment.
Let's bump this to 1.0.0?
index.d.ts
Outdated
| export class AnalyticsDispatcher { | ||
| constructor(dispatch: DispatchAnalytics, context?: AnalyticsContext); | ||
| withContext(context: AnalyticsContext): AnalyticsDispatcher; |
There was a problem hiding this comment.
These types need to remain somehow for legacy support
AvivRubys
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the api more "functional", and makes adding extension methods easier - no need to change the dispatcher prototype